feat: do not use Object.defineProperty?

nix-js/runtime-ts/src/builtins/attrs.ts

@@ -4,6 +4,7 @@
 
 import type { NixValue, NixAttrs, NixList } from "../types";
 import { forceAttrs, forceString, forceFunction, forceList } from "../type-assert";
+import { createThunk } from "../thunk";
 
 export const attrNames = (set: NixValue): string[] => Object.keys(forceAttrs(set)).sort();
 
@@ -22,17 +23,13 @@ export const hasAttr =
 export const mapAttrs =
   (f: NixValue) =>
   (attrs: NixValue): NixAttrs => {
-    const forced_attrs = forceAttrs(attrs);
+    const forcedAttrs = forceAttrs(attrs);
-    const forced_f = forceFunction(f);
+    const forcedF = forceFunction(f);
-    const new_attrs: NixAttrs = {};
+    const newAttrs: NixAttrs = {};
-    for (const key in forced_attrs) {
+    for (const key in forcedAttrs) {
-      Object.defineProperty(new_attrs, key, {
+      newAttrs[key] = createThunk(() => forceFunction(forcedF(key))(forcedAttrs[key]));
-        get: () => forceFunction(forced_f(key))(forced_attrs[key]),
-        enumerable: true,
-        configurable: true,
-      });
     }
-    return new_attrs;
+    return newAttrs;
   };
 
 export const removeAttrs =

nix-js/runtime-ts/src/operators.ts

@@ -250,27 +250,5 @@ export const op = {
     return Array.prototype.concat.call(forceList(a), forceList(b));
   },
 
-  update: (a: NixValue, b: NixValue): NixAttrs => {
+  update: (a: NixValue, b: NixValue): NixAttrs => ({ ...forceAttrs(a), ...forceAttrs(b) }),
-    const forcedA = forceAttrs(a);
-    const forcedB = forceAttrs(b);
-    const newAttrs: NixAttrs = {};
-
-    for (const key in forcedA) {
-      Object.defineProperty(newAttrs, key, {
-        get: () => force(forcedA[key]),
-        enumerable: true,
-        configurable: true,
-      });
-    }
-
-    for (const key in forcedB) {
-      Object.defineProperty(newAttrs, key, {
-        get: () => force(forcedB[key]),
-        enumerable: true,
-        configurable: true,
-      });
-    }
-
-    return newAttrs;
-  },
 };