feat: lots of optimization
* allocate vm stack on the stack * use Rc instead of Arc * optimize recursive attribute set
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
use std::cell::OnceCell;
|
||||
use std::sync::Arc;
|
||||
use std::rc::Rc;
|
||||
|
||||
use crate::builtins::env;
|
||||
use crate::bytecode::{BinOp, OpCode, OpCodes, Program, UnOp};
|
||||
@@ -65,11 +65,11 @@ impl<'vm> VM<'vm> {
|
||||
unsafe { &*(&self.funcs[idx] as *const _) }
|
||||
}
|
||||
|
||||
pub fn eval(&self, opcodes: OpCodes, env: Arc<Env<'vm>>) -> Result<Value<'vm>> {
|
||||
pub fn eval(&self, opcodes: OpCodes, env: Rc<Env<'vm>>) -> Result<Value<'vm>> {
|
||||
let mut stack = Stack::<STACK_SIZE>::new();
|
||||
let mut iter = opcodes.into_iter();
|
||||
while let Some(opcode) = iter.next() {
|
||||
let jmp = self.single_op(opcode, &mut stack, env.clone())?;
|
||||
let jmp = self.single_op(opcode, &mut stack, &env)?;
|
||||
for _ in 0..jmp {
|
||||
iter.next().unwrap();
|
||||
}
|
||||
@@ -85,15 +85,16 @@ impl<'vm> VM<'vm> {
|
||||
&self,
|
||||
opcode: OpCode,
|
||||
stack: &'s mut Stack<'vm, CAP>,
|
||||
env: Arc<Env<'vm>>,
|
||||
env: &Rc<Env<'vm>>,
|
||||
) -> Result<usize>
|
||||
{
|
||||
match opcode {
|
||||
OpCode::Illegal => panic!("illegal opcode"),
|
||||
OpCode::Const { value } => stack.push(Value::Const(value))?,
|
||||
OpCode::LoadThunk { idx } => {
|
||||
self.thunks[idx].capture(env);
|
||||
stack.push(Value::Thunk(self.thunks[idx].clone()))?
|
||||
let thunk = self.get_thunk(idx);
|
||||
thunk.capture(env.clone());
|
||||
stack.push(Value::ThunkRef(self.get_thunk(idx)))?
|
||||
}
|
||||
OpCode::LoadValue { idx } => {
|
||||
stack.push(self.get_thunk(idx).force(self)?)?;
|
||||
@@ -123,7 +124,7 @@ impl<'vm> VM<'vm> {
|
||||
}
|
||||
OpCode::Func { idx } => {
|
||||
let func = self.get_func(idx);
|
||||
func.env.get_or_init(|| env.captured());
|
||||
func.env.get_or_init(|| env.clone().captured());
|
||||
stack.push(Value::Func(func))?;
|
||||
}
|
||||
OpCode::UnOp { op } => {
|
||||
@@ -167,13 +168,13 @@ impl<'vm> VM<'vm> {
|
||||
OpCode::AttrSet => {
|
||||
stack.push(Value::AttrSet(AttrSet::empty()))?;
|
||||
}
|
||||
OpCode::RecAttrSet => {
|
||||
let new = env.enter_rec();
|
||||
stack.push(Value::RecAttrSet(RecAttrSet::new(new)))?;
|
||||
}
|
||||
OpCode::FinalizeRec => {
|
||||
env.enter(stack.tos()?.clone().unwrap_attr_set().into_inner());
|
||||
stack.tos_mut()?.as_mut().unwrap_attr_set().capture(env.clone());
|
||||
},
|
||||
OpCode::PushStaticAttr { name } => {
|
||||
let val = stack.pop();
|
||||
stack.tos_mut()?.push_attr(Symbol::new(name), val);
|
||||
stack.tos_mut()?.push_attr(Symbol::new(name.clone()), val);
|
||||
}
|
||||
OpCode::PushDynamicAttr => {
|
||||
let val = stack.pop();
|
||||
@@ -183,21 +184,21 @@ impl<'vm> VM<'vm> {
|
||||
stack.tos_mut()?.push_attr(sym, val);
|
||||
}
|
||||
OpCode::Select { sym } => {
|
||||
stack.tos_mut()?.force(self)?.select(Symbol::new(sym))?;
|
||||
stack.tos_mut()?.force(self)?.select(&Symbol::new(sym))?;
|
||||
}
|
||||
OpCode::SelectOrDefault { sym } => {
|
||||
let default = stack.pop();
|
||||
stack
|
||||
.tos_mut()?
|
||||
.force(self)?
|
||||
.select_with_default(Symbol::new(sym), default)?;
|
||||
.select_with_default(&Symbol::new(sym), default)?;
|
||||
}
|
||||
OpCode::SelectDynamic => {
|
||||
let mut val = stack.pop();
|
||||
val.force(self)?;
|
||||
val.coerce_to_string();
|
||||
let sym = val.unwrap_const().unwrap_string().into();
|
||||
stack.tos_mut()?.force(self)?.select(sym)?;
|
||||
stack.tos_mut()?.force(self)?.select(&sym)?;
|
||||
}
|
||||
OpCode::SelectDynamicOrDefault => {
|
||||
let default = stack.pop();
|
||||
@@ -208,26 +209,26 @@ impl<'vm> VM<'vm> {
|
||||
stack
|
||||
.tos_mut()?
|
||||
.force(self)?
|
||||
.select_with_default(sym, default)?;
|
||||
.select_with_default(&sym, default)?;
|
||||
}
|
||||
OpCode::HasAttr { sym } => {
|
||||
stack.tos_mut()?.force(self)?.has_attr(Symbol::new(sym));
|
||||
stack.tos_mut()?.force(self)?.has_attr(&Symbol::new(sym));
|
||||
}
|
||||
OpCode::HasDynamicAttr => {
|
||||
let mut val = stack.pop();
|
||||
val.coerce_to_string();
|
||||
let sym = val.unwrap_const().unwrap_string().into();
|
||||
stack.tos_mut()?.force(self)?.has_attr(sym);
|
||||
stack.tos_mut()?.force(self)?.has_attr(&sym);
|
||||
}
|
||||
OpCode::LookUp { sym } => {
|
||||
let sym = Symbol::new(sym);
|
||||
stack.push(
|
||||
env.lookup(Symbol::new(sym.clone()))
|
||||
env.lookup(&sym)
|
||||
.ok_or_else(|| Error::EvalError(format!(r#""{sym}" not found"#)))?,
|
||||
)?;
|
||||
}
|
||||
OpCode::EnterEnv => match stack.pop() {
|
||||
Value::AttrSet(attrs) => env.enter(attrs.into_inner()),
|
||||
Value::RecAttrSet(attrs) => env.enter(attrs.into_inner()),
|
||||
_ => unreachable!(),
|
||||
},
|
||||
OpCode::LeaveEnv => {
|
||||
|
||||
Reference in New Issue
Block a user